Order of scm update! and has_changes?
We have encountered a problem that cerberus does not know that the build gets fixed even if it does get fixed.
This is due to the fact that cerberus performs an scm update and then checks the status resulting from the update. The correct way to do it would be to check if there are modifications, and if there are, then perform the update.
Attached is a patch that fixes this issue regarding svn.
I don't have any experience on the other scm implementations so I don't know how to check for modifications without doing the update on those systems.
-
svn_fix.diff
997 Bytes
-
Craig- Assigned user set to Craig
- State changed from new to accepted
-
Craig
I guess I'm not following exactly what is happening that is wrong?
Cerberus would have run the test suite and entered a failing state and marked that currently checked out revision as failing.
The next time Cerberus runs, it see's that it is in a failed state and does the scm update to pull in any new changes if they have been committed. If there are new changed that were pulled down from the scm update, then the test suite is run again and checked for pass fail.
What issues exactly where you seeing by running the scm update where it originally was? I'm not understanding how you were getting into a use-case where Cerberus didn't recognize the codebase had been fixed?
-
Craig
- State changed from accepted to invalid
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.